Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(balance): necromancers and masters spawn late instead of evolving #3863

Merged
merged 2 commits into from
Dec 14, 2023
Merged

feat(balance): necromancers and masters spawn late instead of evolving #3863

merged 2 commits into from
Dec 14, 2023

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Dec 9, 2023 •
edited by scarf005
Loading

Purpose of change

Alternative solution to resolve #3725

Describe the solution

  1. Moved zombie necromancers and masters out of GROUP_ZOMBIE_UPGRADE...
  2. And instead, put spawns of them at equivalent weights in all monstergroups that had mon_zombie as the default spawn, with starts values set to 500 and 1000 respectively. Cost multiplier nudged down a bit since total potential spawns are getting a bit more concentrated in a few fewer groups.
Affected monstergroups:
  • GROUP_ZOMBIE_POOL
  • GROUP_NECROPOLIS
  • GROUP_NECROPOLIS_SEWERS
  • GROUP_NECROPOLIS_VAULT
  • GROUP_ZOMBIE_FIRELOOKOUTTOWER
  • GROUP_MIL_BASE_CIVILIAN
  • GROUP_RESORT_MIXED
  • GROUP_RESORT_MIXED_STAFF
  • GROUP_RESORT_STAFF
  • GROUP_RESORT_BOUNCER
  • GROUP_ZOMBIE
  • GROUP_POLICE
  • GROUP_HOUSE
  • GROUP_PREPPER_HOUSE
  • GROUP_PHARM
  • GROUP_ELECTRO
  • GROUP_GROCERY
  • GROUP_CHURCH_ZOMBIE
  • GROUP_MANSION
  • GROUP_MALL
  • GROUP_ZOMBIE_SEXSHOP_A
  • GROUP_ZOMBIE_SEXSHOP_B
  • GROUP_ZOMBIE_GUNSTORE

Only cases of "default is just a regular zed" I didn't add them too was GROUP_VANILLA and GROUP_PLAIN, for obvious reasons.

Describe alternatives you've considered

Waiting for the author of the other PR to respond to proposed feedback.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested.

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Dec 9, 2023
@chaosvolt chaosvolt mentioned this pull request Dec 9, 2023
Closed
5 tasks
@scarf005 scarf005 self-requested a review December 9, 2023 22:30
@scarf005 scarf005 self-assigned this Dec 9, 2023
scarf005
scarf005 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it adds a bit of duplicate code but i think this approach would suit better when more advanced zombie variants per region are added.

@scarf005 scarf005 merged commit 07cc56e into cataclysmbnteam:main Dec 14, 2023
11 checks passed
@chaosvolt chaosvolt deleted the necro-posting branch December 14, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarf005 scarf005 scarf005 approved these changes

Assignees

@scarf005 scarf005

Labels
JSON related to game datas in JSON format.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaosvolt @scarf005